Thanks for the heads-up!

On 01.02.2019 22:00, Romain Beauxis wrote:
Some of the future changes have in mind are:
- Remove transitions in fallback/switch operators. As noticed in #695, these transitions do not often work as expected and make the code more complicated. They can be handled in smart_crossfade where they would work as expected.

Let me know what are you guys thoughts on these changes and, in particular, if some of y'all do use crossfade instead of smart_crossfade for a specific reason and the same with fallback/switch transitions.

I'd just like to know if our specific use of transitions on fallback is possible with smart_crossfade? Basically, what we do is start a separate program (through SystemD) when we detect silence on our live source, and stop that program when there is sound again. That program then notifies us about the problem in a Slack channel and keeps running to assist us, and also notifies us when the problem is fixed (in other words, when the program receives SIGTERM). This is implemented in our LiquidSoap script like this:

# Functions for transitioning to and from silence/error
def silence_start(from, to)
    system("sudo --non-interactive /bin/systemctl start silence-notifier")
    fade.initial(to, duration=1.)
end

def silence_stop(from, to)
    system("sudo --non-interactive /bin/systemctl stop silence-notifier")
    fade.initial(to, duration=1.)
end

# Live radio source
radio = input.alsa()
radio = mksafe(radio)
radio = strip_blank(max_blank=12., min_noise=0.3, threshold=-45., 
track_sensitive=false, radio)

# Backup error source
error = # some infallible source, in our case playlist.safe(...)

# Our usage of transitions
stream = fallback(track_sensitive=false, [radio, error], 
transitions=[silence_stop, silence_start])
# ...

This is working very well with our current setup, and I could not see any good way of achieving this with smart_crossfade, at least not with the version documented at https://www.liquidsoap.info/doc-1.3.6/reference.html#smart_crossfade. I generally don't see how you would go about setting up specific transitions depending on what source you are transitioning to, without using transitions in fallback or switch? I hope at least parts of this functionality can be kept in one way or another.

Thanks!
Romain



Le ven. 1 févr. 2019 à 14:32, Romain Beauxis <notificati...@github.com <mailto:notificati...@github.com>> a écrit :

    This is a pre-release for testing purposes! Changelog at the time:

    New:

     *

        Added |(to_){string,float,int,bool}_getter| operators to
        handle getters in script side.

     *

        Made |p| parameter in |smooth_add| a |float| getter (#601
        <https://github.com/savonet/liquidsoap/issues/601>)

     *

        Added |source.time| to get a source's clock time.

     *

        Added support for |aacgain|, thanks to @mdurys
        <https://github.com/mdurys> (#702
        <https://github.com/savonet/liquidsoap/pull/702>)

    Changed:

     *

        Remove dynamic plugin build option.

     *

        Made |on_end| delay a float getter.

     *

        Reimplemented |fade.{in,initial,out,final}| as scripted
        operators. (#664 <https://github.com/savonet/liquidsoap/pull/664>)

     *

        Reimplemented |open_process_full| to get a hand on |pid| and
        finer-grained closing workflow (#703
        <https://github.com/savonet/liquidsoap/pull/703>)

    —
    You are receiving this because you are subscribed to this thread.
    View it on GitHub
    <https://github.com/savonet/liquidsoap/releases/tag/1.4.0-alpha1>
    or unsubscribe
    
<https://github.com/savonet/liquidsoap/unsubscribe_via_email/Am23y0Foaa_xX_N9fjiaWXl_tsmxutQnks5vJKQygaJpZM4ALp3M>
    from all notifications for this repository.

    _______________________________________________
    Savonet-users mailing list
    Savonet-users@lists.sourceforge.net
    <mailto:Savonet-users@lists.sourceforge.net>
    https://lists.sourceforge.net/lists/listinfo/savonet-users



_______________________________________________
Savonet-users mailing list
Savonet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-users

--
Kind regards
Thorben Werner Sjøstrøm Dahl

_______________________________________________
Savonet-users mailing list
Savonet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-users

Reply via email to