Hi, This is the perfect type of feeback I was looking for! I'm keeping this active and will try to resume work on this branch ASAP.
Thank you! Romain Le ven. 15 mars 2019 à 16:39, John Warburton <j...@johnwarburton.net> a écrit : > On Thu, Mar 14, 2019 at 2:08 AM Romain Beauxis <romain.beau...@gmail.com> > wrote: > >> The PR for the crossfade rewrite is pending here: >> https://github.com/savonet/liquidsoap/pull/705 >> >> Perhaps you could give it a try? Essentially, the only thing you should >> have to change is that the simple `crossfade` is removed and >> `smart_crossfade` is renamed `crossfade`. >> > Hi Romain, > > I have experimented with this pull, in the branch "remove-simple-cross". > Metadata value "liq_start_next" brought from the annotate protocol doesn't > appear to have any effect, whereas it used to dictate exactly when the next > track began—quite an important factor in the 'sound' for which I aim. > Therefore, at the moment, some of the transitions are far looser than the > sound that's hoped for. > > Looking for "liq_start_next", the master tree has it in /src/operators/ > cross.ml, but it is not in the pull you suggested, except in the function > "overlap_sources()". > > Is there a way the new 'crossfade' operator can be made to (1) only > overlap and (2) use "liq_start_next" as the old 'crossfade' operator did? > > with best wishes, > John >
_______________________________________________ Savonet-users mailing list Savonet-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/savonet-users
