Am Mittwoch, den 06.08.2008, 15:44 +0200 schrieb Christopher Bratusek:
> Am Mittwoch, den 06.08.2008, 15:36 +0200 schrieb Janek Kozicki:
>
> > Christopher Bratusek said: (by the date of Wed, 06 Aug 2008 00:02:02
> > +0200)
> >
> > > ... That patch again breaks building with CFLAGS="-Wall -ansi
> > > -pedantic".
> > > Can someone please fix that. I don't want to do that again now.
> > >
> > > It's of course low priority, but it would be nice. Thanks
> >
> >
> > I think that after it's fixed, we should keep those flags. You did a
> > lot of work after all, to get rid of all those warnings.
> >
> > How do you set those flags? Currently I did:
> >
>
>
> pass them to configure
>
> CFLAGS="-Wall -ansi -pedantic" ./configure --prefix=/usr
>
>
> >
> > --- configure.in (revision 4263)
> > +++ configure.in (working copy)
> > @@ -332,7 +332,7 @@
> > dnl set explicitly, add some warning options. Turn off implicit-int
> > dnl warnings since the X11 includes on Solaris generate a lot of
> > these if test "x${GCC}" = "xyes" -a "x$CFLAGS" = "x-g -O2"; then
> > - CFLAGS="${CFLAGS} -Wall -Wmissing-prototypes -Wno-implicit-int"
> > + CFLAGS="${CFLAGS} -Wall -ansi -pedantic"
> > fi
> >
> >
> > With diff above I tried compiling and fixed just this one:
> >
> >
> > Index: src/windows.c
> > ===================================================================
> > --- src/windows.c (revision 4263)
> > +++ src/windows.c (working copy)
> > @@ -80,7 +80,7 @@
> >
> > static repv gravity_map[StaticGravity+1];
> >
> > -// In sawfish-1.3.3, the only callback used is keymap_prop_change.
> > +/* In sawfish-1.3.3, the only callback used is keymap_prop_change. */
> > struct prop_handler {
> > struct prop_handler *next;
> > repv prop;
> > Index: configure.in
> >
> >
> > Then I got compilation errors in rep.h (included from client.h). So we
> > could become -pedantic only after rep-gtk is released.
> >
>
>
> No rep.h is part of librep, not rep-gtk. get the current trunk of
> librep, which has both headers
> (rep.h and rep_subrs.h) fixed, you'll see, that it is still broken.
>
>
>
> > So I won't be able to fix those errors, because I'd need to
> > backport rep-gtk on my system...
> >
>
>
> Chris
>
> GNOME/Sawfish rule!fixed. patch waiting for review: http://sawfish.wikia.com/wiki/Another_cleanup Chris GNOME/Sawfish rule!
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
