Hi, all. On Sat, 22 Aug 2009 23:11:50 +0200, J$(D+d(Brgen H$(D+S(Btzel wrote: > Yes. commit message was a bit lazy. I obeyed the multiline commit > message because i thought the intention was obvious.
Thank you all our diligent patch contributors, but please, everyone, be kind enough. If patch sender thinks "Well, it's easy. I can save this _tiniest_ labor of writing ChangeLog.", you have saved it which is NOT tiny. There actually is a labor, and it's a REAL labor for committer, so please, please take that burden on behalf of the maintainer. Furthermore, maintainers (in fact, all) don't know everything. (Just like offline world, so not surpring at all.) For example, our previous leader Janek Kozicki doesn't speak lisp. So virtually there's no "easy enough" patch. Also, giving a short and correct description is not easy, even if it is your own code. (I know I often have given clumsy explanations.) But git commiters have to write a log for others' too. It's more demanding. For example, Chris asked if it "lets us correctly exit", but J$(D+d(Brgen's original email is titled "proper termination of rep interpreter (unload DSOs...)". The latter, especilly "unload ..." seems more appropriate, but what's DSO? Dinamically shared object? It is not strictly necessary, but it's better to record what was wrong with the previous status, I mean, what was the harm, or potential one? Lo, we've already seen one proof that the proper passage is not easy. The email subject looks to have been given in best way, but if it is applied as-is to git log, it's not best. It depends on cricumstance. And it's recorded! I often do "git log" to search for what's happened. But if the item is given poor description (incorrect, off point, short, etc) ... imagine. Do future developers have to decipher, imagine, and prove the meaning of past patch? I don't like to be so indifferent. (If you make it custom to write logs for your own code, then you know it's often hard to read off what you meant the other day.) But, ** take it easy **. :) Just try your best in account of the patch, too, in addition to coding. No one's god, and perfection is not expected. Anyway, thank you very, very much, J$(D+d(Brgen H$(D+S(Btzel, for good patches. Because this kind of thing is frequent, I just wanted to take this occasion to tell. Teika (Teika kazura)
