Christopher Roy Bratusek <[email protected]> writes:
>
> ... Well I've got a question: some sawfish modules spit out *invalid*
> compiler-warnings, just like fdo-menu did (eg wm.misc or wm.user), as
> you fixed them for fdo-menu successfully, could you please fix the other
> modules, too? Of course it's not that important, as they work, but it
> just looks better :)
>
> Thanks for your efforts,
> Chris
Well, the errors associated with wm.misc and wm.user appear to be
fixed (see attached patches). It seems they needed to open
wm.ext.error-handler, and wm.ext.error-hander had to export the function
'error-handler-function. This gets rid of the error messages when compiled.
Cheers,
--
Matthew Love
diff --git a/lisp/sawfish/wm/misc.jl b/lisp/sawfish/wm/misc.jl
index a6718db..52c7bde 100644
--- a/lisp/sawfish/wm/misc.jl
+++ b/lisp/sawfish/wm/misc.jl
@@ -28,7 +28,8 @@
rep.module-system
rep.io.files
sawfish.wm.windows.subrs
- sawfish.wm.events))
+ sawfish.wm.events
+ sawfish.wm.ext.error-handler))
(defvar *user-module* nil)
diff --git a/lisp/sawfish/wm/user.jl b/lisp/sawfish/wm/user.jl
index bab45ab..c164d4d 100644
--- a/lisp/sawfish/wm/user.jl
+++ b/lisp/sawfish/wm/user.jl
@@ -46,6 +46,7 @@
sawfish.wm.util.groups
sawfish.wm.util.display-window
sawfish.wm.util.compat
+ sawfish.wm.ext.error-handler
sawfish.wm.ext.fdo-menu)
(set-binds))
diff --git a/lisp/sawfish/wm/ext/error-handler.jl b/lisp/sawfish/wm/ext/error-handler.jl
index 2638a5f..8eb249a 100644
--- a/lisp/sawfish/wm/ext/error-handler.jl
+++ b/lisp/sawfish/wm/ext/error-handler.jl
@@ -22,7 +22,8 @@
(define-structure sawfish.wm.ext.error-handler
(export retrieve-errors
- display-errors)
+ display-errors
+ error-handler-function)
(open rep
rep.system
