Am Sat, 12 Dec 2009 14:43:32 +0900 (JST) schrieb Teika Kazura <[email protected]>:
> On Tue, 8 Dec 2009 15:47:50 +0100, Christopher Roy Bratusek wrote: > > Am Tue, 08 Dec 2009 13:55:03 +0900 (JST) > > schrieb Teika Kazura <[email protected]>: > > > >> The change is done in commit 6071da, by Jeremy. Let's wait for > >> him. (Well, he seems to be busy. ;) > > > > Hmm... nope, the problem exists for years now, see: > > > > https://bugzilla.gnome.org/show_bug.cgi?id=104591 > > Oops, sorry Jeremy. > > And, sorry Chris. I replied by only skimming, not by understanding > what you said. > > Is what you want: > before: > -- > | | > |A | ------ > | | |trayer| > -- ------ > > after: > ----- > | | > | A |------ > | |trayer| > ----- ------ > > But afterwards, A is fully maximized, right? It's by restart? By restart, that's why altering wm-spec.jl is necessary, plus: the hunk is fully correct if you ask me. Just to make sure: before: -- | | |A |----- | | B | -- ----- B is trayer, A is maximized horizontally and vertically, now on restart the window is maximized (of course ignoring trayer): -------------------- | | | A | | | -------------------- | B | -------- And this is the bug. MAX_HORZ + MAX_VERT != MAX With the patch you'll get the correct behaviour: -- | | |A |------- | | B | -- ------- B is trayer, A is maximized horizontally and vertically, now on restart the window is maximized (of course ignoring trayer): -- | | |A |------- | | B | -- ------- As it should be. ^^^^^^^^^^^^^^^^^^^^^^^^ This is the wm-spec.jl hunks effect now on maximize.jl: before: Window is unmaximized: -- | | -- Window gets maximized horinzontally --------- | | --------- Window gets maximized vertically ---------- | | | | | | | | ---------- For me, this doesn't make sense. So with the patch: Window is unmaximized: -- | | -- Window gets maximized horinzontally --------- | | --------- Window gets maximized vertically -- | | | | | | | | -- This is what I expect, for maximize-window-horizont/vertically. NOTE: This is not valid for the -toggle variants, as I interpret toggle as set state and keep, so the -toggle variants both before and after the patch work like this: Window is unmaximized: -- | | -- Window gets maximized horinzontally (toggle) --------- | | --------- Window gets maximized vertically (toggle) ---------- | | | | | | | | ---------- Of course untoggling works as before, too. Regards, Chris > I've tried similar case with restart, but your patch doesn't help. > (With matcher, set A 'avoid', and max'ize another window for all > directions. Ok, it avoids A. Now restart, and A is covered.) It also > contains definition change for horiz/vert max'n, but it's not natural > save bugfix, so can't be adopted. Of course it's good that a > workaround > > By the way, do you set 'avoid' property to trayer from rc / config? > Is it saved with history? > > If win A and trayer have fixed size, then there's another workaround: > use grow, and save dimension and size, by matcher or window history. > > I guess the cause is window-history or matcher. In general, these two > and the startup procedure is a blackbox, and needs review. I can't say > anything more for sure on this issue now. > > Teika (Teika kazura) >
