Hello,
I had a look into my source. There is no initDbFilter called in sc_search of
my code and Bens usecase works with my version. I do not know who did put it
there (I hope not me...). It is definitely wrong and can simply be removed.
Looking to the history shows that originally initDbFilter was used to
allocate the dbFilter, if not yet happened. But it did not change an
existing one. Now it only initializes the filter, because memory is handled
completely inside of the filter object. So before initDbFilter was necessary
at sc_search, no it is wrong...
As I have no rights in git....
Regards, Gerd
-----Ursprüngliche Nachricht-----
Von: Fulvio [mailto:f...@libero.it]
Gesendet: Donnerstag, 17. November 2011 12:09
An: Ben Hague
Cc: SCIDUsers
Betreff: Re: [Scid-users] Search within search results
Ben Hague wrote:
> Hi,
> I commonly search within search results, e.g. search for a player, and
then search for games they've played with a particular opening. This no
longer works (with git code), as the second search ignores the And option
and searches the whole database. This seems to be because of the
initDbFilter(db); line within the sc_search function in the tkscid.cpp file
in the src directory. I know there's been quite a bit of work done on
searches recently, is this a known byproduct?
>
>
No, thanks for signaling the bug.
In the git version I wrote code to address this common use case, using the
tree window, and i'd like to know if you find it more user friendly or not.
1) Search for a player (usually an opponent)
2) Open the tree window and the best games window
3) In the tree window there is a check button "all games": if checked, games
and stats include all the database; if not, results include only the games
of the searched player.
I usually start with the "all games" unchecked, to see the openings and the
lines played.
When i found a position that was never played or a line that i consider
interesting i check the "all games" and take a look at how the strongest
players have played that position in the most recent games.
Naturally, the AND in the search function is more flexible and must be
fixed.
Bye,
Fulvio
----------------------------------------------------------------------------
--
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Scid-users mailing list
Scid-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scid-users
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Scid-users mailing list
Scid-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scid-users
