Steve A wrote: > You say it has been reverted (a month after you made the hack), but it > is hard to verify as you have quite a lot of database backend > restructuring in this huge commit, poorly named "A lot of code cleanup > and simplification", and the original name frequency code is certainly > not in the same place.
For accuracy and to properly defend my reputation, I would deny even this other false accusation. At line 284 there was a 5 line comments clearly describing the hack: http://sourceforge.net/p/scid/code/ci/9274b0b6999061dd0abdd50a4499a28982d453b5/tree/src/namebase.cpp At line 180 of the same file, in the same function, there is now a 2 line comment: // *** Compatibility *** // even if frequency is no longer used we still need to write these bytes http://sourceforge.net/p/scid/code/ci/master/tree/src/namebase.cpp For full transparency, I would like to publish also the beginning of the email referred by Gregor: /**********/ Hi Fulvio, I see that in newest Scid release you have changed the thing with the frequency count, this is of course a good idea. But I'm sure that you have to increase the database version number, because this change breaks the compatibility to other versions (Scid vs PC, Scid on the Go), even to older Scid versions. /**********/ and my last reply (after an interesting exchange of details on the improvement he made to scidb database and a new format which he is working on): /**********/ Hi Gregor, yes, i committed 255 as a quick fix because I have little free time now. I hope that case1 is highly unlikely, partly because power users who compile the git code usually compact the gamefile before the namefile; am I wrong? I will look more carefully at the code more calmly, however, and write the correct statistics in the namefile because I do not want to change the version of the database now. /**********/ Fulvio ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ Scid-users mailing list Scid-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/scid-users
