Hi Steve,
I feel these two patches will make the moves visualisation feature
more legible and flexible to end users
These include
1. make the move number font bold
2. make the move arrow longer specifically wrt boardVisualiseMoves
3. pick the move number font color from a new option, which the user
can control, which inturn by default set to red
Picking it from GlobalTextColor forces user to globally change the
text color everywhere, when many a times because of the chess set
used, one may want to change the color only for the movenumber shown
on the analysis board.
NOTE: Something seems to have changed wrt avoiding partial PVs from
the engine overriding previous depth full pv visualisation, I need to
see why the latest subversion release/eviision has changed this
behaviour later.
On Sun, Dec 8, 2024 at 12:37 PM Steve A <stevena...@gmail.com> wrote:
>
> Yeah, it wasn't too legible yesterday. I reverted the num colour to default
> text colour, and tweaked the arrow head. The blue is just what I have set as
> options-colours-enginearrows. I'll have to document it all.
>
> Cheers
>
> On Sunday, December 8, 2024, C Hanish Menon <hanish...@gmail.com> wrote:
>>
>> Hi Steve
>>
>> Was modifying things from yesterday's release, to send patch to you. But
>> will checkout the new revision from SVN before sending any patch.
>>
>> Also looking at the image, I can see a reason why there may be some
>> differences in what we have been saying and inturn trying to achieve wrt
>> visualisation themeing around this feature
>>
>> For me the default scidvcpc setup shows a more fancy chess set and also the
>> lines are black with text also black on top & also shorter arrow lines, in
>> your yesterday's commit. All of which makes the move visualisation theme
>> (predefined line colour, line length) you had forced ;) in yesterday's
>> revision non legible.
>>
>> I was about to submit a patch with blue longer lines and red text on top and
>> also changing to bold font. Those changes were to make things more legible.
>>
>> However from your image it appears like now you have also changed the lines
>> to blue & made it longer. So that should potentially resolve the confusion &
>> conflict in our patches
>>
>> PS: yes agree the match is favouring Ding now, given that the cost of risk
>> is lot more now. However it's Gukesh who is trying to add some spice into
>> the mix. Given their positions wrt championship both their behaviours is
>> understandable. Here in India, in general, we root for Gukesh, but equally
>> love Ding :)
>>
>>
>> On Sun, Dec 8, 2024, 08:48 Steve A <stevena...@gmail.com> wrote:
>>>
>>> Ok, Hanish's feature is looking nice - nearly finialized - and is included
>>> in subversion now.
>>> (I've modified it a bit, so not exactly how Hanish envisioned it, sorry
>>> mate).
>>> Check out svn and after installation select "Show Board" and "Sequential"
>>> in the tools->Analysis window.
>>> Screenshot attached. Cheers, S.A.
>>>
>>>
>>> On Sun, Dec 8, 2024 at 1:07 PM Steve A <stevena...@gmail.com> wrote:
>>>>
>>>> Ok... I sorted out some issues today. Control+Wheelmouse will resize the
>>>> board now (hopefully... the focus/flow for these bindings is hard to
>>>> understand).
>>>> You're welcome to update help.tcl if you like... I haven't got around to
>>>> it yet.
>>>>
>>>> > 3. the reason why I had not used engineLineColor is to allow for the
>>>> situation where one can see the different 1st moves suggested by the
>>>> analysis engine (which uses engineLineColor, if I am not wrong) as
>>>> well as the move sequence wrt main pv
>>>>
>>>> Yeah... for sure. But i think it's better to keep them separate, rather
>>>> than having to zero the spinbox.
>>>>
>>>> > Because otherwise users will have to click the middle mouse button
>>>>
>>>> I agree, it's not a great UI element/design, having to use the middle
>>>> button.
>>>> But the default is settable in Tools->analysis config widget
>>>>
>>>> > PS: I have a background in computer science, rather I keep jumping
>>>> between things and languages based on what I am doing (like watching
>>>> the chess championship this time)
>>>>
>>>> Yes - very interesting championship isn't it ! :)
>>>> I have to say I'm going for Ding though, after the huge struggles he's had
>>>> the last couple of years. Gukesh certainly has the form this year, but
>>>> *maybe* his youth will be to his detriment this time... ? I guess from
>>>> your name you are Indian(?) and going for Gukesh :)
>>>>
>>>> regards, Steve
--
Keep ;-)
HanishKVC
Index: tcl/lang/english.tcl
===================================================================
--- tcl/lang/english.tcl (revision 3492)
+++ tcl/lang/english.tcl (working copy)
@@ -250,6 +250,7 @@
menuText E OptionsMainLineColour "Mainline Arrows" 0 {Mainline arrows}
menuText E OptionsVarLineColour "Variation Arrows" 0 {Variation arrows}
menuText E OptionsEngineLineColour "Engine Arrows" 0 {Engine arrows}
+menuText E OptionsEngineMoveColour "Engine Arrow MoveNum" 0 {Move number on Engine arrow}
menuText E OptionsRowColour "Rows" 0 {Default tree/book row color}
menuText E OptionsHighlightColour "Highlight" 0 {Default text highlight color}
menuText E OptionsSwitcherColour "Switcher" 0 {Default db switcher color}
Index: tcl/menus.tcl
===================================================================
--- tcl/menus.tcl (revision 3492)
+++ tcl/menus.tcl (working copy)
@@ -1392,6 +1392,8 @@
set helpMessage($m,1) OptionsVarLineColour
$m add command -label OptionsEngineLineColour -command SetEngineLineColour
set helpMessage($m,1) OptionsEngineLineColour
+$m add command -label OptionsEngineMoveColour -command SetEngineMoveColour
+set helpMessage($m,1) OptionsEngineMoveColour
$m add command -label OptionsRowColour -command SetRowBackgroundColour
set helpMessage($m,1) OptionsRowColour
$m add command -label OptionsSwitcherColour -command SetSwitcherColour
@@ -1443,6 +1445,15 @@
updateAnalysisWindows
}
+proc SetEngineMoveColour {} {
+ global engineMoveColor
+ set temp [tk_chooseColor -initialcolor $engineMoveColor -title [tr OptionsEngineMoveColour]]
+ if {$temp != {}} {
+ set engineMoveColor $temp
+ }
+ updateAnalysisWindows
+}
+
proc SetRowBackgroundColour {} {
global rowcolor
set temp [tk_chooseColor -initialcolor $rowcolor -title [tr OptionsRowColour]]
Index: tcl/start.tcl
===================================================================
--- tcl/start.tcl (revision 3492)
+++ tcl/start.tcl (working copy)
@@ -440,6 +440,7 @@
set ::board::arrowWidth 2
set ::board::arrowLength 0.6
set engineLineColor $maincolor ;# Engine arrows
+set engineMoveColor red ;# Engine arrow move numbers
set rowcolor lightsteelblue1 ;# Tree/Crosstab/Book line/row bg color
set highlightcolor gray85 ;# Nameditor /playerinfo/ crosstable player name highlight colour
set switchercolor lightsteelblue3 ;# DB switcher
Index: tcl/tools/analysis.tcl
===================================================================
--- tcl/tools/analysis.tcl (revision 3492)
+++ tcl/tools/analysis.tcl (working copy)
@@ -3764,14 +3764,10 @@
$board create line $coord -fill $::engineLineColor -arrow last -width 2 -arrowshape {4 7 3} -tag bvm
# and the move number midway along the line
-
- # Get text widget fg color in case we are using a custom foreground S.A.
- set numColor [.analysisWin$n.hist.text cget -foreground]
-
set xmid [expr ([lindex $coord 0] + [lindex $coord 2]) / 2]
set ymid [expr ([lindex $coord 1] + [lindex $coord 3]) / 2]
# $board create text [expr $xmid+1] [expr $ymid+1] -fill [gradient $::engineLineColor -.5] -font $::analysis(boardSeqFont) -text $im -anchor c -tag bvm
- $board create text $xmid $ymid -fill $numColor -font $::analysis(boardSeqFont) -text $im -anchor c -tag bvm
+ $board create text $xmid $ymid -fill $::engineMoveColor -font $::analysis(boardSeqFont) -text $im -anchor c -tag bvm
}
}
}
Index: tcl/tools/analysis.tcl
===================================================================
--- tcl/tools/analysis.tcl (revision 3490)
+++ tcl/tools/analysis.tcl (working copy)
@@ -3683,7 +3683,7 @@
# Hmmm - all boards have to have the same font size
set fontSize [expr ($analysis(boardSize) * 5 + 20)/2 - 2]
- set analysis(boardSeqFont) "{courier 10 pitch} $fontSize"
+ set analysis(boardSeqFont) "{courier 10 pitch} $fontSize bold"
set ::board::_coords($w.frame.bd) $::boardCoords
::board::coords $w.frame.bd
@@ -3748,6 +3748,7 @@
proc boardVisualizeMoves {board n moves visCount} {
$board delete bvm
set im 0
+ set arrowShrink [expr $::board::arrowLength*0.33]
foreach cm $moves {
incr im
if {$im > $visCount} {
@@ -3759,7 +3760,7 @@
set sq_end [::board::sq [string range $cm 2 3]]
# Show an arrow between start and end squares
- set coord [::board::mark::GetArrowCoords $board $sq_start $sq_end $::board::arrowLength]
+ set coord [::board::mark::GetArrowCoords $board $sq_start $sq_end $arrowShrink]
$board create line $coord -fill $::engineLineColor -arrow last -width 2 -arrowshape {4 7 3} -tag bvm
# and the move number midway along the line
_______________________________________________
Scidvspc-users mailing list
Scidvspc-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scidvspc-users
