Hi Parul, Sorry for the silence! Sometimes we are busy and these PRs fall through the cracks.
I'm doing a quick review of your code right now but I don't see any questions regarding parameters on the issue itself? For the gallery example, whatever code you used to apply the method to `data.astronaut` is probably a good choice for the example! Juan. From: Parul Sethi <parul1se...@gmail.com> <parul1se...@gmail.com> Reply: scikit-image@googlegroups.com <scikit-image@googlegroups.com> <scikit-image@googlegroups.com> Date: 23 September 2016 at 3:54:43 PM To: scikit-image@googlegroups.com <scikit-image@googlegroups.com> <scikit-image@googlegroups.com> Subject: Re: Implementing Kadir and Brady's saliency detector in skimage? Hi, I opened a PR regarding this Saliency detection algorithm few days back (#2299). Though the implementation is complete, i required some suggestions regarding parameters(mentioned there). Can any scikit-image maintainer please review it once. Thanks On Thu, Jul 28, 2016 at 11:33 AM, Parul Sethi <parul1se...@gmail.com> wrote: > So sorry for the long pause. > > Thankyou for the response! > I'll soon be done with it. > On 11 Jul 2016 4:11 am, "Stéfan van der Walt" <stef...@berkeley.edu> > wrote: > >> Hi Parul >> >> We are happy to evaluate any PR for inclusion. Saliency detection is >> within scope. >> >> Best regards >> Stéfan >> On Jul 6, 2016 05:54, "parul sethi" <parul1se...@gmail.com> wrote: >> >>> Hi, >>> >>> I required to use Kadir and Brady's saliency detector for feature >>> extraction process, and didn't found it's python implementation. So, i was >>> in process of implementing the same. >>> Will it be of interest to skimage too? I can use some advice from >>> skimage maintainers to build it with specific suitability for skimage >>> module. >>> >>> Thank you. >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "scikit-image" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to scikit-image+unsubscr...@googlegroups.com. >>> To post to this group, send email to scikit-image@googlegroups.com. >>> To view this discussion on the web, visit https://groups.google.com/d/ >>> msgid/scikit-image/7132cb6e-e66f-45be-a71a-327a2e5ff7d9% >>> 40googlegroups.com >>> <https://groups.google.com/d/msgid/scikit-image/7132cb6e-e66f-45be-a71a-327a2e5ff7d9%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> You received this message because you are subscribed to a topic in the >> Google Groups "scikit-image" group. >> To unsubscribe from this topic, visit https://groups.google.com/d/ >> topic/scikit-image/FzZ1VkJt-Ks/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> scikit-image+unsubscr...@googlegroups.com. >> To post to this group, send email to scikit-image@googlegroups.com. >> To view this discussion on the web, visit https://groups.google.com/d/ >> msgid/scikit-image/CABDkGQ%3D%2BcAy%3DLzc5MOR-CzummOuWiyDWrvoN_mXNX% >> 2BNBh868Ew%40mail.gmail.com >> <https://groups.google.com/d/msgid/scikit-image/CABDkGQ%3D%2BcAy%3DLzc5MOR-CzummOuWiyDWrvoN_mXNX%2BNBh868Ew%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- Parul Sethi (student) B.Tech (IT & Mathematical innovation) Cluster Innovation Centre Delhi University -- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscr...@googlegroups.com. To post to this group, send email to scikit-image@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/scikit-image/CAFgV4O5DumqYxW-a0zm5vU9bd459TUpX2Ov9OhLbMNSc%3D%3DxgKg%40mail.gmail.com <https://groups.google.com/d/msgid/scikit-image/CAFgV4O5DumqYxW-a0zm5vU9bd459TUpX2Ov9OhLbMNSc%3D%3DxgKg%40mail.gmail.com?utm_medium=email&utm_source=footer> . For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscr...@googlegroups.com. To post to this group, send an email to scikit-image@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/scikit-image/CA%2BJHcKQtdcbAQjVeBvtOXikCDzMuSzqsFVm4VZO-cZxD2%3D9MkQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.