On Tue, Dec 6, 2011 at 12:07 PM, Olivier Grisel <[email protected]> wrote: > 2011/12/6 Vlad Niculae <[email protected]>: >> >> On Dec 6, 2011, at 11:04 , Gael Varoquaux wrote: >> >>> On Tue, Dec 06, 2011 at 09:41:56AM +0200, Vlad Niculae wrote: >>>> This is actually exactly how the module is designed. >>> >>> Great design! I should have looked at it closer before writing my mail. >>> >>>> We have BaseDictionaryLearning which only implements transforms. I >>>> didn't try but you should be able to instantiate a >>>> BaseDictionaryLearning object, set its components_ manually, and use >>>> its transform. >>> >>> Maybe we need a subclass of this object, for instance 'sparse_coder' that >>> takes as __init__ argument the dictionnary to be used. >> Sounds good, this way it can be used in pipelines. I'll make a pull request. > > Also vlad can you check the shape of the output of: > > http://scikit-learn.org/dev/modules/generated/sklearn.decomposition.sparse_encode.html > (and its' parallel variant) ? > > It looks wrong to me. I would have expected `(n_samples, n_components)` > instead.
There's no really wrong or right here, but indeed it's backwards than the dictionary learning framework, but it's shaped like the linear estimators. I was lead to the same problem when implementing the sparse coder discussed above. Also I think that the defaults should be more consistent between sparse_coding functions and DictionaryLearning objects. I also ran into some missing documentation. I'll put this in a form of a pull request in a couple of minutes, so we can discuss there. Vlad > -- > Olivier > http://twitter.com/ogrisel - http://github.com/ogrisel > > ------------------------------------------------------------------------------ > Cloud Services Checklist: Pricing and Packaging Optimization > This white paper is intended to serve as a reference, checklist and point of > discussion for anyone considering optimizing the pricing and packaging model > of a cloud services business. Read Now! > http://www.accelacomm.com/jaw/sfnl/114/51491232/ > _______________________________________________ > Scikit-learn-general mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/scikit-learn-general ------------------------------------------------------------------------------ Cloud Services Checklist: Pricing and Packaging Optimization This white paper is intended to serve as a reference, checklist and point of discussion for anyone considering optimizing the pricing and packaging model of a cloud services business. Read Now! http://www.accelacomm.com/jaw/sfnl/114/51491232/ _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
