I am not against this but I have to admit I don't fully understand the motivation as _get_params basically inspects the __init__.py hence is already visible to the user.
could you write a tiny piece of code that would make the decision obvious? Alex On Mon, Jan 16, 2012 at 2:37 PM, Olivier Grisel <[email protected]> wrote: > 2012/1/16 Mathieu Blondel <[email protected]>: >> I want to make _get_params public (i.e., rename it to get_params) and > > I would +1 to make this method "optional yet recommended API for well > behaved scikit-learn style estimators". If we do so, we should update > the contributors guide to make this explicit. > > In particular, that would allow complex model selection architectures > (alternatives to our GridSearchCV) implemented outside of the > scikit-learn code base to rely upon this undocumented feature of all > the scikit-learn estimators (as inherited from the base class). > > -- > Olivier > http://twitter.com/ogrisel - http://github.com/ogrisel > > ------------------------------------------------------------------------------ > RSA(R) Conference 2012 > Mar 27 - Feb 2 > Save $400 by Jan. 27 > Register now! > http://p.sf.net/sfu/rsa-sfdev2dev2 > _______________________________________________ > Scikit-learn-general mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/scikit-learn-general ------------------------------------------------------------------------------ RSA(R) Conference 2012 Mar 27 - Feb 2 Save $400 by Jan. 27 Register now! http://p.sf.net/sfu/rsa-sfdev2dev2 _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
