2012/1/20 Andreas <[email protected]>:
> On 01/20/2012 11:07 PM, [email protected] wrote:
>> I wonder if the Decision Tree base estimator could derive from a more 
>> general base estimator for Random Forests and just, for example, override a 
>> setup method or a constructor?
>>
>>
> This seems like a very good idea.
> It's definitely better than what I would have come up with.
>
> So the idea is that the meta estimator checks whether it got an estimator
> derived from the base estimator and if so, calls some setup procedure?

I would rather have a `Bagging` base class (abstract or concrete, I
don't know) with an overridable base`_pre_fit(self, X, y)` method that
can precompute a dictionary of additional fit parameters to pass to
the underlying classifier and make the `BaseForest` inherit from
`Bagging` and override `_pre_fit` to compute `X_argsorted`.

WDYT?

-- 
Olivier
http://twitter.com/ogrisel - http://github.com/ogrisel

------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Scikit-learn-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general

Reply via email to