2012/5/2 Alexandre Gramfort <[email protected]>: > hi Rob, > >> I would like to merge Jake Vanderplas's work >> https://github.com/jakevdp/pyCRFsuite into scikit-learn. I have gotten >> tacit approval in the irc channel. >> >> I am curious since this code requires crfsuite. Should that also be >> bundled, or should I just throw an exception if it can't be found? > > we ship all external dependencies to minimize install problems so > we would need to ship it as we do with libsvm/liblinear > > you could open a pull request that lists things that remain to be done.
I think the main issue with building such a wrapper for crfsuite is that the internal memory layout of crfsuite cannot be directly mapped to numpy array nor scipy sparse matrices hence the wrapper needs to do a memory copy of the training set. Nevertheless I think that would be an interesting contrib. As Alexandre said the discussion on the integration details should better be done on a pull request. -- Olivier http://twitter.com/ogrisel - http://github.com/ogrisel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
