I'd rather avoid importing high-level modules like `neighbors` in low-level
modules like `metrics`...
Also, can't we just postpone the code factorization of affinity
computations to later? After all, we are talking of only a few lines of
code that concern only 2 modules so far.
And I'm still -1 for putting non-PSD kernels in pairwise_kernels :)
PR:
https://github.com/scikit-learn/scikit-learn/pull/803
Mathieu
On Sun, Aug 26, 2012 at 10:21 PM, Andreas Mueller
<[email protected]>wrote:
> Hi everybody.
> I am working on the "pairwise" PR atm since I think it is high time that
> this gets merged.
> Without it, it's basically impossible to reasonably test any clustering
> algorithms and
> it fixes what I think is a bit hole in the API.
> As Olivier suggested I tried to move all affinity computations into
> pairwise_kernel.
> I stumbled across a problem that seems a bit odd and now I don't know
> what to do:
> I wanted to put the nearest neighbors affinity into the metrics module,
> but the neighbors
> module imports the metrics module, so there is a circularity problem.
> Is there an easy way to fix this?
>
> Otherwise I'd prefer to get the API in the best possible shape so we can
> merge, and
> add other affinities later. I really don't like having code lie just
> because we could
> add more and more features.
>
> Cheers,
> Andy
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Scikit-learn-general mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Scikit-learn-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
