On 09/25/2012 11:19 PM, Olivier Grisel wrote: > I think we could have `classes=None` constructor parameter in > SGDClassifier an possibly many other classifiers. When provided we > would not use the traditional `self.classes_ = np.unique(y)` idiom > already implemented in some classifiers of the project (but not all). > > +1 also for raising a ValueError exception when `classes != None` and > if the `y` provided at fit time has some values not in `classes`. > However we need to check with some benchmarks that this integrity > check is not too costly. > > This constructor parameters could be overriden by a `fit_param` to > preserve backward compat, especially for classifier models with a > `partial_fit` method. Could you explain why this is necessary. Whey wouldn't the default value do the same as the current version?
Thanks, Andy ------------------------------------------------------------------------------ How fast is your code? 3 out of 4 devs don\\\'t know how their code performs in production. Find out how slow your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219672;13503038;z? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
