It is different, I was only concerned about the predict_proba method. Yours appears to be more general.
My code is here if you want to take a look at it https://github.com/flaviovdf/scikit-learn/commit/7c6e60cfe4a796817a0bcf2bb67cd36d5962a1ad I'll keep working with my version until the pull request is merged. -- Flavio On Wed, Oct 3, 2012 at 10:41 AM, Andreas Mueller <[email protected]> wrote: > Hey Flavio. > Sorry for the timing, just saw your mail now. > Does your solution look similar to mine: > https://github.com/scikit-learn/scikit-learn/pull/1201 > I guess you just replaced the specific place where the problem was. > I tried to go with the general procedure used in other estimators. > > Cheers, > Andy > > > On 10/03/2012 02:16 PM, Flavio Vinicius wrote: >> Hello again, >> >> Since I need this now, I used the ``unique`` ideia by Andreas to fix >> locally, works perfectly. Should I still issue the pull request? Or >> are you going to do this Andreas? >> >> -- >> Flavio >> >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/scikit-learn-general > > > ------------------------------------------------------------------------------ > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > _______________________________________________ > Scikit-learn-general mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/scikit-learn-general ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
