Looks good Gael - only thing:
*y* : numpy array of shape [n_samples, n_responses]
Target values
Should probably be:
*y* : numpy array of shape [n_samples, n_targets]
Target values
Presuming targets is meant to be used instead of responses. The same
applies to the docstrings of elastic_net, elastic_net_cv, etc.
On Fri, Nov 9, 2012 at 5:43 PM, Gael Varoquaux <
[email protected]> wrote:
> On Fri, Nov 09, 2012 at 05:33:22PM +0100, federico vaggi wrote:
> > Which is n_responses, n_features (I confused samples and responses
> earlier)..
>
> Actually, I was wrong earlier, and the term that we usually use is
> 'n_targets'.
>
> > It makes sense - assuming it isn't redundant/confusing, I might try to
> do a PR
> > and add a small explanation on the website?
>
> Can you review the commit that I just pushed and tell me if you think
> that it would do it?
>
> Cheers,
>
> Gaël
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_nov
> _______________________________________________
> Scikit-learn-general mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
>
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
_______________________________________________
Scikit-learn-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
