2013/10/3 Lars Buitinck <[email protected]>: > Dear all, > > I was just going through the code for Crab, aka Python-Recsys [1], and > it struck me how incredibly similar their code looks to us. E.g. much > of their metrics.pairwise module [1] and several parts of their utils > are copy-pasted literally from scikit-learn, but without any mention > of scikit-learn or any of our names in the codebase. The metrics > module even contains the line > > euclidian_distances = euclidean_distances # both spelling for > backward compatibility > > which was in our pairwise.py a couple of releases ago, and I very > clearly recognize code that I wrote myself. In fact, the whole project > seems to contain very little original code. > > Has anyone been in touch with these people about this? If not, I can > try to send a PR with proper copyright and attribution. >
They sent an email some time ago to contribute code to scikit-learn. As far I remember there were a lot of frameworkish code that was very specific to the recys task (e.g. database management and user and items) so the work to extract the generic parts was non trivial and it never went further. Please feel free to send them a PR with the copyright attributions (or just ask them to do it by themselves). -- Olivier ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
