2013/12/2 abdalrahman eweiwi <[email protected]>: > Hi, > > You are right, infact I spent almost 1 month reviewing the code base of PLS > and CCA implementation in sklearn. I should say that the (old) code base in > my opinion should be somehow refactored to get into a simpler shape. I > remember I had some difficulties in analyzing that code. Also the CCA > results from sklearn was not right in a couple of applications I tested it > with. Anyway, I sat down and rewrote my own code for PLS,CCA,KPLS which I > use frequently in my applications, and they are fine. I think I should now > evaluate it on a couple of datasets as Oliver has suggested and show you > the results. If you have any advise on how to deal with the current codebase > to integrate my code, I would be glad to listen.
Please feel free to send a link to your current implementation if it's already online (e.g. on http://gist.github.com ) so that Nelle and other interested developers can have a look at it to decide how to best fix / refactor / replace the existing codebase. Writing benchmark script that compare the two implementations is helpful allow with cases that highlight incorrect results from the sklearn implementation. If you do so, please make sure to run an updated master branch of sklearn. If you open issues to report bugs for the current implementation, please mention @NelleV in the description or in the comment so that she will receive a notification as AFAIK she is the dev who worked the most recently on this part of the code base. -- Olivier http://twitter.com/ogrisel - http://github.com/ogrisel ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
