hi, I don't get the problem with this docstring.
it would be great to merge: https://github.com/scikit-learn/scikit-learn/pull/3176 Alex On Thu, May 22, 2014 at 12:15 PM, Kyle Kastner <kastnerk...@gmail.com> wrote: > This looks like it would fix the issue with autochosen n_nonzero_coefs - > which is great! After reading the paper mentioned in the docstring, I can > see where the Gram matrix calculation is coming from now, but I think the > check > > if tol is None and n_nonzero_coefs > len(Gram): > raise ValueError("The number of atoms cannot be more than the number > " > "of features") > > is making sure the number of n_nonzero_coeffs is less than the number of > atoms (which seems to be the limiting factor in using the Gram matrix), not > the number of features. Should this error string also be updated/changed? > > > On Thu, May 22, 2014 at 12:47 AM, Alexandre Gramfort > <alexandre.gramf...@telecom-paristech.fr> wrote: >> >> see >> >> https://github.com/scikit-learn/scikit-learn/pull/3176 >> >> Alex >> >> >> >> ------------------------------------------------------------------------------ >> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE >> Instantly run your Selenium tests across 300+ browser/OS combos. >> Get unparalleled scalability from the best Selenium testing platform >> available >> Simple to use. Nothing to install. Get started now for free." >> http://p.sf.net/sfu/SauceLabs >> _______________________________________________ >> Scikit-learn-general mailing list >> Scikit-learn-general@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/scikit-learn-general > > > > ------------------------------------------------------------------------------ > "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE > Instantly run your Selenium tests across 300+ browser/OS combos. > Get unparalleled scalability from the best Selenium testing platform > available > Simple to use. Nothing to install. Get started now for free." > http://p.sf.net/sfu/SauceLabs > _______________________________________________ > Scikit-learn-general mailing list > Scikit-learn-general@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/scikit-learn-general > ------------------------------------------------------------------------------ Time is money. Stop wasting it! Get your web API in 5 minutes. www.restlet.com/download http://p.sf.net/sfu/restlet _______________________________________________ Scikit-learn-general mailing list Scikit-learn-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
