2014-07-04 10:28 GMT+02:00 Olivier Grisel <[email protected]>: > 2014-07-04 3:35 GMT+02:00 Dayvid Victor <[email protected]>: >> Should I do the classifier setup in the __init__ (passing all arguments of >> the KNN to in the InstanceReduction constructor)? > > You might want to pass a KNN instance as `base_estimator` directly as > the pattern followed in BaggingEstimator for instance.
Yes. It seems like this reduce_data member is really fit in disguise. It trains a k-NN estimator, but then returns the reduced X and y, which I don't really understand. If it just left them as attributes and returned self, it would fit (no pun intended) the current API perfectly, or so it seems. >> Do you think I call it scikits.protopy (use: from scikits.protopy import A) >> in order to be according to the scikits pattern? > > We have abandoned this pattern in sklearn for years as namespace > packages tend to cause a lot of issue with installation tools. IIRC it also significantly slowed down the imports in some circumstances. ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
