Hey Jaret.
It is usually easier to discuss these things on the github issue tracker.
Which is your pull request? Just ask there.
For the doctests you can do "make test-doc" that will run nosetests with
the appropriate options.
For the whitespace, there is an option to ignore whitespace changes.
grep NORMALIZE_WHITESPACE in the code to see an example.
The integration tests do the same as "make test" (basically). They check
multiple versions of numpy, scipy and python, though, which
is not entirely trivial to reproduce (you can create some virtualenvs if
you like).
The "expected" is just the string that is actually written in the
doctest. You need to fix that manually if the output changed.
Hth,
Andy
On 08/05/2015 04:28 PM, Jaret Flores wrote:
After working with the code a little, I have some follow up
questions. Please feel free to point me to other references.
1) Is there a way to run doctest tests for a specific package similar
to `nosetests`? Also, doctest tests seem to be sensitive to
formatting (spacing) and required a couple trials to get it correct.
Are there rules for this?
2) After submitting the pull request, there are continuous integration
tests. Is there anyway to run these tests prior to submitting the
pull request? Also, it seems my request has failed due to a failing
doctest test which passes on my own machine. When looking at the
travis-ci build output, it looks like the code has been updated (the
`Got` is current as per my pull request) but the comment was not (the
`Expected` was not current). I am not sure how to proceed from here.
Thanks again
On Tue, Aug 4, 2015 at 10:08 PM, Andy <t3k...@gmail.com
<mailto:t3k...@gmail.com>> wrote:
Hi Jaret.
It totally depends on your what your interested in and familiar with.
The issue tracker has lots of issues to fix, look at the "easy"
issues, the "need contributor" ones or the "bug" ones.
And definitely look at the contributing section:
http://scikit-learn.org/dev/developers/contributing.html#contributing-code
Code reviews of existing pull requests are also always welcome of
course.
After doing some "easy" fixes I can point you to more challenging
ones.
Cheers,
Andy
On 08/04/2015 10:18 PM, Jaret Flores wrote:
Since I've come into a good amount of free time lately, I wanted
to find a way to contribute. As it says in the documentation, I
wanted to check here to see what would be a good use of my time.
If anyone has suggestions as to where I should devote some time,
please let me know. Thanks.
-Jaret
------------------------------------------------------------------------------
_______________________________________________
Scikit-learn-general mailing list
Scikit-learn-general@lists.sourceforge.net
<mailto:Scikit-learn-general@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
------------------------------------------------------------------------------
_______________________________________________
Scikit-learn-general mailing list
Scikit-learn-general@lists.sourceforge.net
<mailto:Scikit-learn-general@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
------------------------------------------------------------------------------
_______________________________________________
Scikit-learn-general mailing list
Scikit-learn-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
------------------------------------------------------------------------------
_______________________________________________
Scikit-learn-general mailing list
Scikit-learn-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
