+1 On 28 August 2015 at 04:23, Andreas Mueller <t3k...@gmail.com> wrote:
> I think it would be fine to enable it now without support in all solvers. > > > On 8/27/2015 11:29 AM, Valentin Stolbunov wrote: > > Joel, I see you've done some work in that PR. Is an additional review all > that's needed there? Looks like changes in Logistic Regression CV broke the > original contribution and it has since stalled (over 1 year ago). > > I guess the big question is: what is the best way to get sample weights in > LR? Would it be to wait for progress in that PR and have weights for all > solvers, or simply "enable" them in the other two solvers via the rough > steps I outlined earlier? > > On Wed, Aug 26, 2015 at 9:59 PM, Andy <t3k...@gmail.com> wrote: > >> On 08/26/2015 09:29 PM, Joel Nothman wrote: >> > I agree. I suspect this was an unintentional omission, in fact. >> > >> > Apart from which, sample_weight support in liblinear could be merged >> > from https://github.com/scikit-learn/scikit-learn/pull/2784 which is >> > dormant, and merely needs some core contributors to show interest in >> > merging it... >> > >> "merely" ;) >> >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> Scikit-learn-general mailing list >> Scikit-learn-general@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/scikit-learn-general >> > > > > ------------------------------------------------------------------------------ > > > > _______________________________________________ > Scikit-learn-general mailing > listScikit-learn-general@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/scikit-learn-general > > > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Scikit-learn-general mailing list > Scikit-learn-general@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/scikit-learn-general > >
------------------------------------------------------------------------------
_______________________________________________ Scikit-learn-general mailing list Scikit-learn-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
