Hi Valery.
I didn't include them because the Chi2 worked better for my task ;)
In hindsight, I'm not sure if these kernels are not to a bit too specialized for scikit-learn. But given that we have the (slightly more obscure) SkewedChi2 and AdditiveChi2, I think the intersection one would be a good addition if you found it useful.

Andy

On 12/03/2016 03:39 PM, Valery Anisimovsky via scikit-learn wrote:
Hello,

In the course of my work, I've made samplers for intersection/Jensen-Shannon kernels, just by small modifications to sklearn.kernel_approximation.AdditiveChi2Sampler code. Intersection kernel proved to be the best one for my task (clustering Docstrum feature vectors), so perhaps it'd be good to add those samplers alongside AdditiveChi2Sampler? Should I proceed with creating a pull request? Or, perhaps, those kernels were not already included for some good reason?

With best regards,
-- Valery
_______________________________________________
scikit-learn mailing list
scikit-learn@python.org
https://mail.python.org/mailman/listinfo/scikit-learn

_______________________________________________
scikit-learn mailing list
scikit-learn@python.org
https://mail.python.org/mailman/listinfo/scikit-learn

Reply via email to