Honestly not sure what the core dev's preference is, but maybe just submit it as a PR and take the discussion (for a potential removal, inclusion, or move of these features to the documentation) of the additional plotting features from there.
Best, Sebastian > On Sep 14, 2017, at 9:42 PM, L Ali <nj.yua...@gmail.com> wrote: > > Hi Sebastian, > > Thanks for your quick response, there are two functions in my code will > output a chart using matplotlib. Do you know how can I discussing the PR via > an issue with the main devs? Sorry for such stupid questions. > > Thanks again for your advise. > > Li Yuan > > From: Sebastian Raschka > Sent: Thursday, September 14, 2017 9:36 PM > To: Scikit-learn mailing list > Subject: Re: [scikit-learn] Help needed > > Hi, Li, > > to me, it looks like you are importing matplotlib in your code, but > matplotlib is not being installed on the CI instances that are running the > scikit-learn unit tests. Or in other words, the Travis instance is trying to > execute an "import matplotlib..." and fails because matplotlib is not > installed there. Except for the docs, I think matplotlib code is not being > tested in scikit-learn's unit tests (and hence, it's not being installed). > Does your code/contribution require matplotlib or is it just imported "by > accident"? If the latter is true, simply removing matplotlib imports will > prob. solve the issue; otherwise, I guess discussing the PR via an issue with > the main devs might be the way to go. > > Best, > Sebastian > > > On Sep 14, 2017, at 9:24 PM, L Ali <nj.yua...@gmail.com> wrote: > > > > Hi guys, > > > > I am totally new to the scikit-learn, I am going to submit a pull request > > to the repository, but always got following error message, I could not find > > any usefully information from Google, my last hope is our community. > > > > Is there anyone can give me some advise about this error: > > ModuleNotFoundError: No module named 'matplotlib' > > > > Thanks so much! > > > > <F29260EB7C164340BDED515E54DA3883.png> > > > > Li Yuan > > > > <F29260EB7C164340BDED515E54DA3883.png>_______________________________________________ > > scikit-learn mailing list > > scikit-learn@python.org > > https://mail.python.org/mailman/listinfo/scikit-learn > > _______________________________________________ > scikit-learn mailing list > scikit-learn@python.org > https://mail.python.org/mailman/listinfo/scikit-learn > > _______________________________________________ > scikit-learn mailing list > scikit-learn@python.org > https://mail.python.org/mailman/listinfo/scikit-learn _______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
