I think you mean keyword-only, Alex

On Tue., 17 Sep. 2019, 4:11 pm Alexandre Gramfort, <
alexandre.gramf...@inria.fr> wrote:

> Yes I am +1 for positional arguments for the __init__ of the estimators.
>
> Alex
>


Albert: my position when reviewing changes in accordance with this SLEP
would be to (a) perhaps get usage evidence as discussed in the SLEP pull
request review; and (b) apply a rule of thumb like "are the semantics
reasonably clear when the argument is passed positionally?" I think they
are clear for PCA's components, for Pipeline's steps, and for
GridSearchCV's estimator and parameter grid. Other parameters of those
estimators seem more suitable for keyword-only.

Trickier is whether n_components in TSNE should follow PCA in being
positional... It's not as commonly set by users.

>
_______________________________________________
scikit-learn mailing list
scikit-learn@python.org
https://mail.python.org/mailman/listinfo/scikit-learn

Reply via email to