Not a core contributor, but what's with the "_in" bit? Just go with a public n_features which I think a bunch of estimators already have? Feels clumsy
On Wed, Dec 4, 2019 at 8:22 PM Andrew Howe <ahow...@gmail.com> wrote: > Excellent idea. > > > <~~~~~~~~~~~~~~~~~~~~~~~~~~~> > J. Andrew Howe, PhD > LinkedIn Profile <http://www.linkedin.com/in/ahowe42> > ResearchGate Profile <http://www.researchgate.net/profile/John_Howe12/> > Open Researcher and Contributor ID (ORCID) > <http://orcid.org/0000-0002-3553-1990> > Github Profile <http://github.com/ahowe42> > Personal Website <http://www.andrewhowe.com> > I live to learn, so I can learn to live. - me > <~~~~~~~~~~~~~~~~~~~~~~~~~~~> > > > On Tue, Dec 3, 2019 at 10:14 PM Nicolas Hug <nio...@gmail.com> wrote: > >> As per our Governance <http://scikit-learn.org/stable/governance.html> >> document, changes to API principles are to be established through an >> Enhancement Proposal (SLEP) from which any core developer can call for a >> vote on its acceptance. >> >> *SLEP010: n_features_in attribute *is up for a vote. Please see >> https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest/slep010/proposal.html >> >> *This SLEP proposes the introduction of a public n_features_in_ attribute >> for most estimators* >> >> Core developers are invited to vote on this change until 4 January 2020 >> by replying to this email thread. >> >> All members of the community are welcome to comment on the proposal on >> this mailing list, or to propose minor changes through Issues and Pull >> Requests at https://github.com/scikit-learn/enhancement_proposals/. >> _______________________________________________ >> scikit-learn mailing list >> scikit-learn@python.org >> https://mail.python.org/mailman/listinfo/scikit-learn >> > _______________________________________________ > scikit-learn mailing list > scikit-learn@python.org > https://mail.python.org/mailman/listinfo/scikit-learn >
_______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
