Andy To be honest, I've kind of outgrown matplotlib, and do all my viz with plotly. It's much less mature of a package, and the documentation seems to leave much to be desired. However, the interactivity and html/javascript basis is worth that trade-off for me. So yes, ultimately, I'd like to see tree_plot generate tree visualizations with which the user can interact. Same for all sklearn plots, really.
The tree rotation is not something I want - I'd never found it useful in other applications. Just figured I would mention it as feedback. I'd go with you on deleting the arg. Andrew <~~~~~~~~~~~~~~~~~~~~~~~~~~~> J. Andrew Howe, PhD LinkedIn Profile <http://www.linkedin.com/in/ahowe42> ResearchGate Profile <http://www.researchgate.net/profile/John_Howe12/> Open Researcher and Contributor ID (ORCID) <http://orcid.org/0000-0002-3553-1990> Github Profile <http://github.com/ahowe42> Personal Website <http://www.andrewhowe.com> I live to learn, so I can learn to live. - me <~~~~~~~~~~~~~~~~~~~~~~~~~~~> On Wed, Dec 4, 2019 at 4:14 PM Andreas Mueller <t3k...@gmail.com> wrote: > Hey Andrew. > Thanks for your feedback! > > On 12/4/19 5:19 AM, Andrew Howe wrote: > > Hi Andy > > I've been playing around with plot_tree for a while (clearly), and have > some feedback finally. I'm not very concerned with the compactness of the > tree. However, for large trees, it's not very easy to inspect or traverse. > I think it could be very useful to add the following ways to > *slice-and-dice* the tree: > > - plot_tree_subtree_node - plots only the portion of the tree that > could be accessed by traversing downwards from the specified node > - plot_tree_subtree_class - plots the entire tree, highlighting all > the traversals that lead to a specific class, other class leaf / branch > nodes could be shrunk to save space > > Somehow I feel like an interactive visualization would be more useful for > that. Don't you think? > There are tree exploration tools that we could run in jupyter. > If we can do it with just CSS (which is actually reasonably plausible), > then we could ship this with scikit-learn. > That would be completely orthogonal to the matplotlib based code, though. > I had thought about whether it might make sense to do a html based tree > visualization recently and thought it might actually be nicer than the > matplotlib one. > Thoughts? > > Also, I have noted on ver 0.21.3 that the rotate argument does not seem to > be working in either jupyter lab or ipython, though this seems like a known > issue. > > There seems to be a recent issue: > https://github.com/scikit-learn/scikit-learn/issues/15694 > > Is that a feature you really want? That's just me copying something I > didn't mean to copy, and it's not implemented at all. > We could implement it, but I was leaning towards just deleting it. > > Cheers, > Andy > > > Andrew > > <~~~~~~~~~~~~~~~~~~~~~~~~~~~> > J. Andrew Howe, PhD > LinkedIn Profile <http://www.linkedin.com/in/ahowe42> > ResearchGate Profile <http://www.researchgate.net/profile/John_Howe12/> > Open Researcher and Contributor ID (ORCID) > <http://orcid.org/0000-0002-3553-1990> > Github Profile <http://github.com/ahowe42> > Personal Website <http://www.andrewhowe.com> > I live to learn, so I can learn to live. - me > <~~~~~~~~~~~~~~~~~~~~~~~~~~~> > > > On Thu, May 23, 2019 at 4:24 PM Andreas Mueller <t3k...@gmail.com> wrote: > >> Hey Andrew. >> Thanks for saying thanks! >> I share your frustration with export_graphviz, in particular for teaching. >> I feel like plot_tree is not ideal yet, though. In particular the layout >> is not as compact as the graphviz one. >> If you have any feedback or suggestions, I'd be very happy to hear them! >> >> Cheers, >> Andy >> >> >> On 5/23/19 10:39 AM, Andrew Howe wrote: >> >> I want to say thank you to all the sklearn developers. The breadth and >> quality of this software is truly breathtaking. >> >> Specifically, I want to say thank you very very much for the plot_tree >> function! I have wasted a lot of effort in the past, on multiple OSes, >> getting everything to work so I could view the tree.export_graphviz >> results. Having this new function to plot the trees natively in matplotlib >> is extremely useful. >> >> Thanks again! >> Andrew >> >> <~~~~~~~~~~~~~~~~~~~~~~~~~~~> >> J. Andrew Howe, PhD >> LinkedIn Profile <http://www.linkedin.com/in/ahowe42> >> ResearchGate Profile <http://www.researchgate.net/profile/John_Howe12/> >> Open Researcher and Contributor ID (ORCID) >> <http://orcid.org/0000-0002-3553-1990> >> Github Profile <http://github.com/ahowe42> >> Personal Website <http://www.andrewhowe.com> >> I live to learn, so I can learn to live. - me >> <~~~~~~~~~~~~~~~~~~~~~~~~~~~> >> >> _______________________________________________ >> scikit-learn mailing >> listscikit-learn@python.orghttps://mail.python.org/mailman/listinfo/scikit-learn >> >> >> _______________________________________________ >> scikit-learn mailing list >> scikit-learn@python.org >> https://mail.python.org/mailman/listinfo/scikit-learn >> > > _______________________________________________ > scikit-learn mailing > listscikit-learn@python.orghttps://mail.python.org/mailman/listinfo/scikit-learn > > > _______________________________________________ > scikit-learn mailing list > scikit-learn@python.org > https://mail.python.org/mailman/listinfo/scikit-learn >
_______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
