Robert Roessler: > I have finished a version of Editor::NotifyModified Undo/Redo > "optimizations"... it would be good if you could check it over WRT > "safety"/"correctness" assumptions.
Containers will no longer see SC_LASTSTEPINUNDOREDO on single step undo so won't know to update UI. The names NotLazyEval and MustEvalForUndoRedo are too generic. Maybe something like CanDeferToLastStep and IsLastStep? > One of the "optimizations" my be controversial (i.e., wrong), but I am > suppressing visual updates on the "before" insert/delete cases, since > the "real" inserts/deletes will be seen *very* shortly. Is this > reasonable? I expect so. > OTOH, some of this happens "for free" in the Windows graphics code - I > would imagine that GTK/GDK tries to do the same, but I do not know > this to be the case. Yes, GTK merges redraws into a redraw region although like Windows it doesn't promise much about this process so could decide that merging two rectangles produces their bounding box or the whole window. > I am not sure precisely what you mean with the "flag indicating if any > of this batch has had lines added or deleted could be used for two of > the checks" - but if it means less screen updating, I am ready! :) The modification performs a full window redraw for every undo even if only a single character is added or deleted. Neil _______________________________________________ Scintilla-interest mailing list [email protected] http://mailman.lyra.org/mailman/listinfo/scintilla-interest
