Neil Hodgson wrote:

Robert Roessler:


Actually, the "no modifications" means to the TEXT in the buffer - you
can still use SCN_MODIFIED to remove STYLING - which is all the
indicators are... I use SCN_MODIFIED with SC_MOD_BEFOREDELETE to
remove indicators myself. :)


   This isn't supposed to work currently due to reentance protection.
Styling changes inside content changes are a reasonable thing to allow
but I haven't changed the code to allow this yet.

   When Scintilla stops you from making a change synchronously, the
solution is to post your application window a message which can then
be processed after the Scintilla code has finished handling the
current change.

We may not be communicating here... I have been using the ability to remove markers AND indicators while handling SCN_MODIFIED for quite some time now. IIRC, you suggested handling markers this way in response to my problems with the marker "residue" being left after lines were deleted - removing the markers in response to a SC_MOD_BEFOREDELETE was the approved method of solving this.

I added indicators to this myself later with no observed problems... I seem to recall you discussing loosening the restrictions even further, for that matter.

So while I can certainly believe that there are some potential reentrancy problems lurking in the general case of buffer modification during notification handling, it would be a lot nicer to institute fine-grained lockouts (maybe even according to which notification is in progress?)... and I would really appreciate it if you do not lock something down further that currently works and break my app! :)

Robert Roessler
[EMAIL PROTECTED]
http://www.rftp.com
_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest

Reply via email to