Neil Hodgson wrote:
Joseph Galbraith:
Please find attached two patches which enable both
scintilla.dll and scite.exe to be build using VS.NET
2005 (or the platform SDK 64 bit compiler.)
Visual C++ 6 is a currently supported platform and will not compile
these changes so references to GWLP_* and [GS]etWindowLongPtr need to
be protected with an #ifdef, such as #ifdef GetWindowLongPtr.
Ugh... I'm pretty sure VC++ 6.0 can use the more recent Platform
SDK that has this stuff (we do it all the time) but it seems to
be a little bit trickier to get it to do so from the command line.
Adding the following to the makefile CXXFLAGS makes it build:
-DLONG_PTR=LPARAM -DGetWindowLongPtr=GetWindowLong
-DSetWindowLongPtr=SetWindowLong -DGWLP_WNDPROC=GWL_WNDPROC
-DGWLP_USERDATA=GWL_USERDATA
But that is probably a little bit gross. Would there be a
better place to put these defines? (Defining these in the
case were they aren't defined seems cleaner to me than
cluttering the code itself up with #ifdefs?)
I'll do it however you'd like though... I just need a 64 bit
build :-)
Why was PASCAL changed to CALLBACK in some places but not others?
It is changed from PASCAL to CALLBACK because that is how it
is defined in the PSDK now. It is only changed someplaces
because I only changed it if I got an error (probably because
something else was different too.)
Is there a real difference here?
Probably not... but I'd say it's best to change these to
match the PSDK.
> I don't recall why PASCAL is
currently used and don't really want to search through CVS logs and
mailing list archives to find out, so it is best to minimize changes
to those required for the patch's purpose.
My guess is that it used to be declared as PASCAL but that
it has been changed. PASCAL and CALLBACK may be equivalent
on s ome platformsbut different on others. I don't know...
that is why I figured do it the way MS does and then it
won't cause problems.
Since I do not know of a decent patch program for Windows, please
send full files rather than patches. Due to their size, they should be
posted to my personal address or added to a new bug on the SourceForge
tracker.
https://sourceforge.net/tracker/?group_id=2439&atid=102439
The ones I'm generating are from subversion (I've imported
the scitilla HEAD so I can work with it.) Is there problems
applying them?
I could send you the results of CVS diff if that would be better.
Or the files are fine too...
Or I can probably figure out how to do gnu diff if I have to.
Thanks,
Joseph
_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest
