Jason Haslam: > I'm working with my own Qt implementation and looking at the changes > I've made in core scintilla code that I may need to merge into the > new release if I decide to update. > > In ExternalLexer.h: > > #if PLAT_WIN > #define EXT_LEXER_DECL __stdcall > #elif PLAT_GTK > #define EXT_LEXER_DECL > #endif > > How is this handled on the other platforms? Shouldn't that be: > > #if PLAT_WIN > #define EXT_LEXER_DECL __stdcall > #else > #define EXT_LEXER_DECL > #endif
It would be up to other platform implementors to work out what to do and send in modifications. There may need to be a choice between OSes even for one platform. Unless someone has worked out what is safe, its probably better to fail compilation. You start to get into issues about whether lexer DLLs should be sharable between Windows-native and Windows-GTK+. The external lexer support is not that often used so could be ignored. > In Editor.cxx: > > #ifndef PLAT_QT > #define INCLUDE_DEPRECATED_FEATURES > #endif This was done by the current Qt platform implementers and I just included what was asked for. Neil _______________________________________________ Scintilla-interest mailing list [email protected] http://mailman.lyra.org/mailman/listinfo/scintilla-interest
