Re: [scintilla] [ scintilla-Bugs-1476445 ] Highlighting problem 
Iago Rubio:


It only happens onto a comment as the parameter "start" is computed as
'styler.GetStartSegment() + 2' that returns the whole line only when the
state is comment.

The call at line 661 reads this way:
scriptLanguage =
    segIsScriptingIndicator(styler,
                            styler.GetStartSegment() + 2,
                            i + 10,
                            eScriptPHP);

Now, I don't know if this failure is about not updating the start
segment on the comment, or it's just this call is bogus and should take
the current position instead of the start segment.


  It looks better if 'styler.GetStartSegment()' is replaced by the
current position 'i' and I think this is reasonable.


I've been also wrestling the - damm slow - sorceforge CVS web interface
looking for this function's cahnges, to check if a comment clarifies it,
but found nothing.


  Yeah. "blame" is reasonably fast to get an overview. We could try
to get the repository monitored by FishEye like other open source
projects but I don't have any time for this. FishEye looks like:
http://fisheye1.cenqua.com/viewrep/python/python/dist/src/Objects/fileobject.c

  This piece of code was probably copied from other uses of
segIsScriptingIndicator where the range is relative to an attribute
and it shouldn't apply to a PHP marker.

  I have committed that change.

  Neil

_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest

Reply via email to