Neil Hodgson wrote:
Jason Haslam:
I ought to have caught this before the release of 1.74, but I didn't
have a chance to test the release candidate. I don't believe that
the use of the __APPLE__ macro for the OS X port is correct. In fact
it breaks my Qt port on OS X. I imagine that it will break the wx
and gtk ports on mac as well.
There are 4 occurrences of __APPLE__. The 2 that are most likely to
cause a break are for WaitMouseMoved which appears unnecessary now
that Scintilla waits for a mouse move before starting a drag.
The others are for determining the default colour and borders of
calltips. These are unlikely to break a build and may actually be the
correct values for other platforms on OS X. Its probably worth adding
some more Platform methods for these aspects to avoid the #ifdefs
completely.
Anyone can jump in and do it, I'm unlikely to participate much till
after OSCON.
Regards,
Shane
_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest
