Martin Stone wrote:
Robert Roessler wrote:
I would like to see it - I trust it doesn't touch too many files. ;)

How many is too many?  I tried to do be as tidy as I could, but there
are two new messages, and that alone affects four files:  SciTERes.h,
SciTE.h, SciTEBase.cxx, and SciTEProps.cxx.  In addition SciTEWin.cxx
has an implementation for KeyUp().  The stack code itself only affects
SciTEBase.h and SciTEBuffers.cxx.

42 (that would be too many)... :)

BTW, I assume you mean "SciTERes.rc" rather than ".h".

The update should be pretty painless -- The patch is a unified diff,
which you can apply from the root directory of the 1.68 source with:

    patch -p1 -u -i ctrltab.patch

(This is my first attempt at building a patch, so do tell me I've done
it wrong.  It works for me, though.)

I glossed over noticing you actually supplied the command, so I got to go and download "patch" from the GnuWin32 project, figure out that

patch -p1 <ctrltab.patch

was an appropriate command (it works), and *then* I realized that you had already told me what to do... rerunning patch with your command informs me that everything is already there, BTW. ;)

Unfortunately, the link is already/currently stale. :(

Doh!  I've now uploaded it to SourceForge as an attachment to a feature
request.  I hope this is acceptable protocol (I'm a SourceForge newbie).
The URL for the patch on SourceForge is

<http://sourceforge.net/tracker/download.php?group_id=2439&atid=352439&f
ile_id=171971&aid=1456865>
(I won't bother with tinyurl.com this time, in case that was part of the
problem -- Apologies if you have to unwrap the URL.)

Well, I did need to join the lines, but that was easy.

I hope you like it!

I do! My two criteria are that a) the code looks "reasonable" (although Neil is of course the arbiter here), and b) that the behavior of Visual Studio is emulated vis-a-vis Ctrl-Tab.

Since your changes seem to qualify on both counts, I am [provisionally] happy. Thanks for doing this and packaging it up so that I could try it for myself.

BTW, Neil usually prefers the actual changed files (as opposed to diffs/patches).

Robert Roessler
[EMAIL PROTECTED]
http://www.rftp.com
_______________________________________________
Scite-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scite-interest

Reply via email to