Hi Kein-Hong Man, OK, I do understand that - you added that call to OnSwitchFile back in February. That fixed the case where you close a file and it switches to another opened buffer. However, OnSwitchFile is still not called for new buffers or when opening a new file, even if we had to make room for the new file by closing an old buffer... and I don't think you intended for it to be called in this case, either.
The steps that Neil used to reproduce the issue are essentially the same ones that I used - creating a new buffer when there's no room for new buffers. There was an issue there, which I found and fixed, but it sounds like you're also seeing a problem with some other test case? (Otherwise you would be smiling instead of clarifying!) Regards, Bruce "Kein-Hong Man" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Bruce Dodson wrote: >> Hi Guys, >> >> The !makingRoomForNew clause needs to be there. For this >> case, since the buffer is being re-initialized, >> InitBuffer has to be called (which happens on line 569) >> instead of ActivateBuffer. >> >> Actually I don't think OnSwitchFile should be called in >> this case, as it is not supposed to be called for new >> buffers - only for switching to an existing buffer. So I >> think the correct fix is probably on line 645: > > Please see the description of the problem in my recent > posting in the thread. > > If we have file A and file B, and we close file B, then > from file B's POV, it is being closed, but from file A's > POV, it has just been reactivated. It's a little like > General Relativity -- the same incident looks different > from the points of view of file A and file B. > >> if (extender && !closingLast && !makingRoomForNew) { >> extender->OnSwitchFile(filePath.AsFileSystem()); >> } >> >> Regards, >> Bruce >> >> >> "Neil Hodgson" <[EMAIL PROTECTED]> wrote in message >> news:[EMAIL PROTECTED] >>> [Redirecting to mailing list as it looks like a Bruce >>> Dodson issue] >>> [snip snip] > > -- > Cheers, > Kein-Hong Man (esq.) > Kuala Lumpur, Malaysia _______________________________________________ Scite-interest mailing list [email protected] http://mailman.lyra.org/mailman/listinfo/scite-interest
