Author: vsiveton Date: Wed Sep 3 14:32:19 2008 New Revision: 691787 URL: http://svn.apache.org/viewvc?rev=691787&view=rev Log: SCM-246: p4 command reports most or all errors on stderr but maven-scm-provider-perforce throws away stderr
o replaced others printStackTrace() by logger.getLogger().error() Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/edit/PerforceEditCommand.java maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/remove/PerforceRemoveCommand.java maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/unedit/PerforceUnEditCommand.java Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/edit/PerforceEditCommand.java URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/edit/PerforceEditCommand.java?rev=691787&r1=691786&r2=691787&view=diff ============================================================================== --- maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/edit/PerforceEditCommand.java (original) +++ maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/edit/PerforceEditCommand.java Wed Sep 3 14:32:19 2008 @@ -74,11 +74,11 @@ } catch ( CommandLineException e ) { - e.printStackTrace(); + getLogger().error( e ); } catch ( IOException e ) { - e.printStackTrace(); + getLogger().error( e ); } if ( consumer.isSuccess() ) Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/remove/PerforceRemoveCommand.java URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/remove/PerforceRemoveCommand.java?rev=691787&r1=691786&r2=691787&view=diff ============================================================================== --- maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/remove/PerforceRemoveCommand.java (original) +++ maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/remove/PerforceRemoveCommand.java Wed Sep 3 14:32:19 2008 @@ -64,11 +64,11 @@ } catch ( CommandLineException e ) { - e.printStackTrace(); + getLogger().error( e ); } catch ( IOException e ) { - e.printStackTrace(); + getLogger().error( e ); } return new RemoveScmResult( cl.toString(), consumer.getRemovals() ); Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/unedit/PerforceUnEditCommand.java URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/unedit/PerforceUnEditCommand.java?rev=691787&r1=691786&r2=691787&view=diff ============================================================================== --- maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/unedit/PerforceUnEditCommand.java (original) +++ maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/unedit/PerforceUnEditCommand.java Wed Sep 3 14:32:19 2008 @@ -65,11 +65,11 @@ } catch ( CommandLineException e ) { - e.printStackTrace(); + getLogger().error( e ); } catch ( IOException e ) { - e.printStackTrace(); + getLogger().error( e ); } if ( consumer.isSuccess() )