I applied your new patch that contains some tabs and failure in add command test. I fixed them, can
you check if my change in clearcase add command is ok?
Emmanuel
Wim Deblauwe a écrit :
Allright, here we go again. I have updated SCM-77 with a new patch.
Hopefully this one will satisfy all your needs :)
if there are any things I should change, please let me know.
For the edit and unedit commands I have used the ScmFileStatus.UNKNOWN,
because I don't know what I should use there. Maybe you guys can put
something better in there.
regards,
Wim
2005/11/19, Emmanuel Venisse <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>>:
Wim Deblauwe a écrit :
> Hey Emmanuel,
>
> 1) I'm using TortoiseSVN to generate the patch. Maybe I did something
> wrong, I never worked with it before.
Strange, it works fine normally.
>
> 2) I sure can. Normally I just let IntelliJ IDEA do my
formatting. Don't
> know if you have the correct settings? Otherwise, i'll just fix
the tabs.
http://maven.apache.org/guides/development/guide-m2-development.html#Maven
Code Style
>
> 3) Well, because I was unable to test and also I could not get the
> logging to work (see one of my previous emails)
clearcase commands print something to console, so, you can copy this
output to text files and parse
them with consumers. You don't need logger for tests, only some
junit assert that verify your
consumer is correct.
>
> 4) I haven't made testclasses yet. Should they really do clearcase
> operations or check if the command line is like it should be?
command line only and test consumers.
>
> I'm out of office now, so I will not be able to do these things
until
> monday.
>
> regards,
>
> Wim
>
> 2005/11/18, Emmanuel Venisse <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>
> <mailto: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>:
>
> Some comments about your patch :
> - How do you have generated it? some files are present more
than one
> time.
> - Can you replace all tab character with 4 spaces?
> - Why your consumers do nothing?
> - Where are test classes?
>
> if you can recreate your patch and integrate all those
remarks, it
> will be more simple to read,
> apply and maintain.
>
> Emmanuel
>
> Wim Deblauwe a écrit :
> > Done: http://jira.codehaus.org/browse/MNG-1622
> >
> > I did not modify the release-plugin.
> >
> > regards,
> >
> > Wim
> >
> > 2005/11/18, Emmanuel Venisse < [EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>
> <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>
> > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
<mailto: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>>:
> >
> > Great.
> >
> > you can create a patch for maven-scm and attach to a
jira issue.
> > I'll review it (and perhaps Dan too).
> >
> > Do you have modify release-plugin?
> >
> > Wim Deblauwe a écrit :
> > > Hi guys,
> > >
> > > I've implemented add, checkin, edit, remove, status and
> tag for
> > > clearcase. Is somebody willing to update the release
> plugin so I can
> > > test? Do I need to create a patch with all my current
> changes for
> > > someone to update the release plugin?
> > >
> > > regards,
> > >
> > > Wim
> >
> >
>
>
