I'm agree.
Lukas Theussl a écrit :
According to [1], the format for a scm url is
scm<delimiter><scm_provider><delimiter><provider_specific_part>
ie, scm:<provider>|<provider specific stuff> would not be a valid form.
I would also find it confusing if there were other colons in one of the
variables, so I think it should not be allowed.
-Lukas
[1] http://maven.apache.org/scm/scm-url-format.html
Dennis Lundberg wrote:
Hi
I've been working with Lukas on the Maven 1 plugins team to resolve an
issue in maven-changelog-plugin for Maven 1. He posed a valid question
in that discussion, which led me to write this message.
SCM-106 makes it possible to use "|" as a separator character between
"scm" and the rest of the scm url. That way you can have *only* ":" or
*only* "|" as your separator.
However it is also possible to use an scm url like the one below, and
it is considered valid in maven-scm-beta-3-SNAPSHOT:
scm:cvs|pserver|[EMAIL PROTECTED]|/home/cvspublic|module
Lukas asked me this:
"Shouldn't the separator be set to the character after the 'scm'?"
My first thought was: of course it should. But when I looked at the
code for maven-scm and found that this is not the case. So as I see it
we have two alternatives here, regarding what url:s are valid:
1. The way it works now
scm:<provider>:<provider specific stuff>
scm:<provider>|<provider specific stuff>
scm|<provider>|<provider specific stuff>
2. More consistent way of handling the separator
scm:<provider>:<provider specific stuff>
scm|<provider>|<provider specific stuff>
The upside of using 2. is that it makes parsing of scm url:s much easier.
The downside of going with 2 is that there might be a few scm url:s
out there using the "scm:<provider>|<provider specific stuff>" format,
which would no longer work.
Thoughts anyone?
