Emmanuel Venisse wrote:
>> getLogger().debug( "executing changelog command..." );
The required change is in
ClearCaseUpdateCommand.java:
protected ChangeLogCommand getChangeLogCommand()
{
return new ClearCaseChangeLogCommand();
}
should be:
protected ChangeLogCommand getChangeLogCommand()
{
ClearCaseChangeLogCommand c= new ClearCaseChangeLogCommand();
c.setLogger(getLogger());
return c;
}
This change must be done in maven-scm-api and not in clearcase provider.
I copied the way it is done in cvs, perforce and starteam providers -
when a command creates other command to execute it - it always sets a
logger on it. In fact as command requires logger to work I would add it
as a constructor param and removed default constructor. But I have no
experience with this code - so I am not sure how to do it at
maven-scm-api level.
2) Checkout fails on Unix:
command.setWorkingDirectory( workingDirectory.getParentFile() );
+1. Simple solutions sometimes are difficult to find during debugging.
3) I do not run ClearCase LT but I do not want to use -vws parameter
for checkout command - my environment is configured to work without it
and in fact I cannot even find a way to make it work with this
parameter from command line. In my opinion the best approach would be
not to use default view storage if one is not present in configuration
file, but skip -vws parameter in command line construction in this
case. If someone wants -vws parameter to be passed he should specify
it in config file.
I don't use Clearcase, so i don't know what is the msot common usage
(-vws or not) but we use it actually as default. I think it will be
better for users to keep it ads default and add the availability in conf
file to don't use it.
Wim, Dan, any thoughts?
In fact - I do not care what the default is if only I can change it - I
am not experienced enough with ClearCase to judge wich one is more common.
I have some other minor issues but these ones are difficult to
workaround.
post them.
I will write separate email on it this week - I am not 100% sure right
now where the fix should be placed (continuum, maven2, or clearcase
provider) but will try to descibe them as well as I can.
Do you want me to create JIRA issues for these 3 issues?
Regards
Piotr
