Hey all, I need code review for:
6805008 cdm.py needs updates to work with hg 1.1 Webrev: onnv: http://cr.opensolaris.org/~richlowe/onnv-cdm11/ cadtest: http://cr.opensolaris.org/~richlowe/cadtest-cdm11/ Notes: There's a (mostly complete) list of the API changes on the Mercurial side here: http://www.selenic.com/mercurial/wiki/index.cgi/API_Changes It's missing the one that hurt us most, however, that repo.workingctx() went away, and repo.changectx(None) now returns the workingctx. We're adjusting for these issues based on version information (rather than checking if objects have the methods we want, or catching appropriate exceptions) at the request of Mike. This drops support for Mercurial versions less than 1.0.2. This is almost entirely for non-technical reasons (keeping the list of "good" versions manageable and sensible, rather than shooting for the widest range possible). Ideally, we'd drop support for 1.0 in general at the earliest opportunity. In going through this, I also corrected some whitespace damage from prior changes. Please look carefully at the udiffs or cdiffs for cdm.py (I can't find a way to cause the other views to care about changes in whitespace). The way we're dealing with versioning is considerably less than ideal (to say the least), I'm unaware of other, better, options we can take. The gate staff will also need to make adjustments to their code prior to the gate machines getting a newer Mercurial. I'd especially like comments from Mike, Mark and Danek, others, of course, are welcome and encouraged. Thanks, -- Rich
