Mike Kupfer writes:
> I've posted a copy of the script and its man page at
> http://cr.opensolaris.org/~kupfer/453/, and I welcome any review
> comments on it.
sccs2hg.1
"Create a Mercurial workspace from an SCCS tree."
I'd suggest making the title less ambiguous about the usage
case -- something like "Migrate Teamware consolidation to
Mercurial."
"should use
.IR wx2hg (1)
instead."
This needs to be stronger (see below). It has to be a MUST
NOT.
sccs2hg.sh
1: missing "-p" here
34: what's the name of this file?
71: nit: I'd use sed's "-n" and add the 'p' option to this command.
The reason would be to avoid doing something bizarre if some
weirdo chose to name a clear file "s.foo" outside of an SCCS
directory.
81,82,86: This isn't needed; sccs get -kp works fine when given the
explicit path of an sccs file. (It's only sccs get
without the -p option that does what you don't want.)
86: recommend including "-s" with the sccs get options to suppress
the annoying SID and line count output.
91: missing quoting on $f.
> I'm wondering how to make the script available. If we think it's okay
> to put back this script into onnv-gate with all our other work, then the
> answer is easy: just add the script to onnv-scm. I'm just not sure how
> many people actually need to use this script. And I'm concerned that
> putting it in SUNWonbld will encourage people to use the wrong script.
> (ON developers should be using wx2hg instead.)
There are a couple of things I think you could do:
- Change the documentation to make it a little clearer who should be
using it. I think it's essentially consolidation-level
gatekeepers only. And it should certainly point out that projects
intending to deliver (putback, push, integrate) _anywhere at all_
MUST NOT use it.
- Make the script deliberately fail if used on an ON workspace.
(Could be detected by walking parent chain or perhaps by looking
for some ON-specific files.)
I see no other good way to distribute it, either, and any way you
distribute it, there will probably be users who stumble into it and do
the wrong thing.
--
James Carlson, Solaris Networking <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
