"Mark J. Nelson" <Mark.J.Nelson at Sun.COM> writes:
> Howdy--
>
> This is a request for a pretty simple move. I filed two bugs, because
> that's what "we" would normally do internally to cover putback to multiple
> gates.
>
> Jim Walker, I'm particularly hoping that you'll look at 498, because this
> is an implicit handoff to you on these tests.
>
> --Mark
>
> 498 tooltest evicted from onnv-scm, needs new home
> http://cr.opensolaris.org/~mjnelson/webrev.498/
>
> ...this one is only marginally more interesting, in that in instantiates
> that tree in the scmtest repository.
>
> When reviewing 498, please keep in mind:
>
> 1. I chose scmtest/src/legacy as a parallel tree to scmtest/src/suites,
> because scmtest/src/suites/scm/README was pretty explicit about use of
> the TET test harness. Since these tests do not use TET, I didn't
> think they belonged there.
>
> 2. I provided a README.legacy file to describe #1.
>
> 3. I wrote a pretty simple set of Makefiles to drive tooltest; any file
> named "Makefile" in the 498 webrev is part of this, and needs to be
> reviewed.
They look fine, to me.
> 4. I provided a README.tooltest file to describe how to use the Makefiles
> from #3.
>
> 5. Only one file changed in the move from onnv-scm to scmtest. That file
> was tooltest.py. Since it's not obvious from either webrev, the
> unified diffs are as follows:
>
> --- scm-fixes/usr/src/tools/onbld/Tests/tooltest/tooltest.py Wed May 14
> 14:42:23 2008
> +++ scmtest/src/legacy/scm/tooltest/tooltest.py Tue May 13 22:11:04 2008
> @@ -95,12 +95,11 @@
> testpath = 'tests'
>
> #
> - # If a module path isn't specified we default to two
> - # levels above the directory containing this executable.
> + # If a module path isn't specified we default to
> + # /opt/onbld/lib/python
> #
> if not mpaths:
> - dirn, fn = os.path.split(progname)
> - sys.path.append(os.path.join(dirn, '../../..'))
> + sys.path.append('/opt/onbld/lib/python')
> else:
> sys.path.extend(mpaths)
That too looks fine to me.
-- Rich
