Looks good. On Tue, 27 May 2008, Richard Lowe wrote:
> Date: Tue, 27 May 2008 23:04:07 -0400 > From: Richard Lowe <richlowe at richlowe.net> > To: scm-migration-dev at opensolaris.org > Subject: [scm-migration-dev] Please review #502 > > > Hey all, > > I'd like code review for: > 502 hg-active should do something more tasteful with KeyboardInterrupt > > http://cr.opensolaris.org/~richlowe/scm_502 > > The vast majority of the change is moving the logic into main(), so > sadly the diff is pretty noisy. > > The actual changes: > - avoid shadowing 'repo' (a nit) > - top-level-comment -> docstring > - catch KeyboardInterrupt, and exit 1, rather than letting it traceback. > > Thanks, > > -- Rich > _______________________________________________ > scm-migration-dev mailing list > scm-migration-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/scm-migration-dev >
