> Please review:
>    522 nightly.1 nits
>    536 README.tools needs to be updated
>
> Webrev: http://cr.opensolaris.org/~richlowe/scm_522

README.tools:

- layout section: does /opt/onbld/lib/python/onbld/hgext deserve a
   separate mention?  As written, it falls under "python modules used by
   the build tools," which isn't how I would describe Cadmium.

- It seems like the entries in the Tool Summary section actually
   correspond to binaries in /opt/onbld/bin[/${MACH}], except for cdm.  I
   guess that's OK, just an observation.  (Some of the others are indirect,
   ie codesign and depcheck aren't named binaries, but correspond to sets
   of binaries.)

nightly.1

- For STAFFER, I think it would read better as "The non-root account
   to use on the build machine for the bringover from the clone or parent
   workspace.  This may not be the same identity used by the SCM."  (Feel
   free to change "SCM" if it's not the right phrase.)


Reply via email to