http://bugs.grommit.com/show_bug.cgi?id=544

           Summary: sccs2hg improvements
           Product: SCM Migration
           Version: unspecified
          Platform: All
        OS/Version: Solaris 11/Nevada
            Status: NEW
          Severity: minor
          Priority: P4
         Component: other
        AssignedTo: scm-migration-dev at opensolaris.org
        ReportedBy: mike.kupfer at sun.com


>From May 2008 review feedback from Jim Carlson:

sccs2hg.1

  "Create a Mercurial workspace from an SCCS tree."

        I'd suggest making the title less ambiguous about the usage
        case -- something like "Migrate Teamware consolidation to
        Mercurial."

  "should use
  .IR wx2hg (1)
  instead."

        This needs to be stronger (see below).  It has to be a MUST
        NOT.

sccs2hg.sh

  1: missing "-p" here

  34: what's the name of this file?
[I think this has already been fixed. -mdk]

  71: nit: I'd use sed's "-n" and add the 'p' option to this command.
      The reason would be to avoid doing something bizarre if some
      weirdo chose to name a clear file "s.foo" outside of an SCCS
      directory.

  81,82,86: This isn't needed; sccs get -kp works fine when given the
            explicit path of an sccs file.  (It's only sccs get
            without the -p option that does what you don't want.)

  86: recommend including "-s" with the sccs get options to suppress
      the annoying SID and line count output.

  91: missing quoting on $f.

On the subject of minimizing confusion about when to use sccs2hg and
when to use wx2hg, Jim wrote:

  There are a couple of things I think you could do:

    - Change the documentation to make it a little clearer who should be
      using it.  I think it's essentially consolidation-level
      gatekeepers only.  And it should certainly point out that projects
      intending to deliver (putback, push, integrate) _anywhere at all_
      MUST NOT use it.

    - Make the script deliberately fail if used on an ON workspace.
      (Could be detected by walking parent chain or perhaps by looking
      for some ON-specific files.)


-- 
Configure bugmail: http://bugs.grommit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to