Will Fiveash <William.Fiveash at Sun.COM> writes: > I never saw a full reply to my comments below. I assume replies should > be on the tools-discuss at opensolaris.org and > scm-migration-dev at opensolaris.org lists.
That's my mistake (I somehow forgot to add them elsewhere too, I apologize). > On Thu, Jun 19, 2008 at 02:34:22PM -0500, Will Fiveash wrote: >> On Fri, Jun 13, 2008 at 11:25:03PM -0600, Mark J. Nelson wrote: >> > >> > Howdy-- >> > >> > Please review this update to the SUNWonbld tools to make them >> > Mercurial-aware. This is the first step towards transitioning ON (and any >> > consolidation relying on these tools) to Mercurial. >> > >> > For most ON developers, nothing will obviously change after this putback. >> > They will continue using the same tools, in the same fashion, in the same >> > teamware workspaces. >> > >> > For anyone working in Mercurial, or for anyone wanting to migrate a >> > workspace to Mercurial, this will give them native support in the >> > SUNWonbld tools. (Read "they will no longer need to download tools from >> > our project page, and can use any maintained ON build machine.") >> > >> > Anyway, more blathering on that forthcoming under separate cover. >> > >> > >> > >> > Here's the webrev: >> > >> > http://cr.opensolaris.org/~mjnelson/toolsreview/ >> >> I did not do a thorough review (time and I don't know python) but here >> are a couple comments: >> >> In >> http://cr.opensolaris.org/~mjnelson/toolsreview/webrev.python/usr/src/tools/onbld/Checks/Comments.py.html: >> 40 arcre = re.compile(r'^([A-Z][A-Z]*ARC[/ \t][12]\d{3}/\d{3}) (.*)$') >> >> - Note that wx is using: >> >> arc='(FW|LS|PS)ARC[\/ ][12][0-9][0-9][0-9]\/[0-9][0-9][0-9][^0-9]' >> >> which is more restrictive. I was told when making this change that >> it was preferable to restrict the ARC regex matches to just FWARC, >> LSARC or PSARC since this list was not likely to change often and it >> was better to catch a misspelled ARC comment. I agree with this, I think. >> In >> http://cr.opensolaris.org/~mjnelson/toolsreview/webrev.python/usr/src/tools/onbld/Checks/DbLookups.py.html >> >> 66 self.__baseURL = "http://hestia.sfbay/cgi-bin/expert?"; >> >> - Given this code will be run both within and outside SWAN I'm thinking >> it would be safer to always use FQDNs so there is no ambiguity. That sounds reasonable. >> In >> http://cr.opensolaris.org/~mjnelson/toolsreview/webrev.python/usr/src/tools/onbld/Checks/__init__.py.html >> >> 48 # >> 49 # Generic check to test if a host is on SWAN >> 50 # >> 51 def onSWAN(): >> 52 try: >> 53 if socket.gethostbyname("sunweb.central.sun.com."): >> 54 return True >> 55 else: >> 56 return False >> 57 except: >> 58 return False >> >> - Perhaps it would be good to test a couple more internal hosts if >> sunweb is down? It's a DNS lookup. I would assume that if you can't resolve sunweb you'd be unable to resolve anything else swan-specific you may wish to use(?). Is there a better way to check for SWAN connectivity other than trying and seeing whether it succeeds? -- Rich
