"James C. McPherson" <James.McPherson at Sun.COM> writes: > Richard Lowe wrote: >> Richard Lowe <richlowe at richlowe.net> writes: >> >>> Dean Roehrich <Dean.Roehrich at Sun.COM> writes: >>> >>>> Well, my team was way behind on cstyle.pl and I finally noticed this...so >>>> I updated from our October 2005 version to the current version. >>>> >>>> This cset: >>>> >>>> changeset: 4950:f0c49956a749 >>>> user: Richard Lowe <richlowe at richlowe.net> >>>> date: Mon Aug 13 20:07:24 2007 -0400 >>>> summary: 306 cdm should whine at people about checks as early as is >>>> sensible >>>> >>>> has the unfortunate side-effect of making cstyle exit after processing one >>>> file, whether or not there were warnings, and no matter how many files are >>>> listed on the commandline. >>>> >>>> Perhaps the following patch would be appropriate. This removes the exit >>>> from >>>> within the while() loop, and moves it up, after the calls to cstyle(). >>>> >> >>> Yes. Can you verify whether jstyle is also a victim? >> >> It does, with a similar fix being appropriate. >> >> I've filed this as #546, attached to #546 is Dean's diff, as well as >> the same change made to jstyle. Does anyone want a webrev, or are >> folks happy reviewing it in bugzilla? > > I reviewed this in bugzilla, the changes look good to me. >
Thanks. -- Rich
