>>> 2) Have we agreed on a new form for the two problem children, >>> #ident/#pragma ident and the modinfo line? And if so, can we specify >>> that exactly to avoid as much thinking as possible when the new >>> requirements are thrust on gatelings innocent of all the discussion >>> and background? >> >> We've floated suggestions as long ago as Steve Lau's KTD, and that was to >> use the output of "hg id" as a unique (indeed, much better than %I%, >> because it applies to the entire workspace, not just one file) identifier. >> >> That said, we've still got some work to do in this regard, tying that into >> the VERSION macro in nightly/make. Invoking "hg id" is expensive, and we >> don't want folks to do that in their individual Makefiles. > > You misunderstand: I don't mean a suggestion for "what to replace them with > to have a useful function", I mean, "What to do with keywords in > newly-put-back files". It's my understanding that all RTIs are obliged to be > fixing this piecemeal now. If not, I didn't understand: > > "Please help catch these as folks are modifying these files for other > tasks so this won't be such an onus at migration time."
Sorry, I parsed your question wrong. But my answer is still the same: for ident lines, whether or not they're part of a #pragma, just leave 'em. For modinfo strings, please cleanse them. > I held up an RTI yesterday until the modinfo string was cleansed. Should I > not be doing that? You're doing the right thing. > Someone's going to be doing a sweep soon, I assume (perhaps you?) Does that > person have an immediate plan for what to do with the %x% strings? For the obvious cases, they're mostly fixed. For the cases where a subject matter expert needs to figure out what to do, we've filed bugs. For the yet-to-be-introduced cases, Val asked the CRT to watch out. >> So for now, the policy really is what Val said. Don't let new, non-ident >> keyword usage in, and we'll have a policy soon for the >> unsightly-but-harmless vestiges in ident lines. Yeah. That. --Mark
